[Webkit-unassigned] [Bug 204114] WebDriver: fix handling of session timeouts for values higher than MAX_INT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204114

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brian Burg from comment #5)
> Comment on attachment 383354 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383354&action=review
> 
> r- because its needs to be rebased.

Ok, that's more a r+ cq- :-)

> Code changes look otherwise fine.
> 
> Only concern: I understand moving from int to Seconds, but not from Seconds
> to double. Is there any practical benefit to using raw double over Seconds
> to represent seconds? It seems like the entire point of Seconds is to
> replace usage of doubles.

IIRC I got rounding errors that made some tests fail. I'll check again, I don't remember now.

> > Source/WebDriver/Session.h:54
> > +    double pageLoadTimeout() const { return m_pageLoadTimeout; }
> 
> Why?
> 
> > Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:269
> > +        JSValueMakeNumber(context, callbackTimeout.valueOr(-1))
> 
> Okay.
> 
> > Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:67
> > +            if (!resultReported && callbackTimeout >= 0)
> 
> Okay.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191217/0f4efddc/attachment-0001.htm>