[Webkit-unassigned] [Bug 205264] Resolve dynamic media queries without reconstructing RuleSets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205264

--- Comment #5 from Emilio Cobos Álvarez (:emilio) <emilio at crisal.io> ---
(In reply to Antti Koivisto from comment #3)
> > @media (width: 0) {
> >   .myclass * { ... }
> > }
> > 
> > Causes "myclass" changes to restyle the whole subtree even if the feature
> > doesn't match. Seems it probably would, but it might be ok.
> 
> With this patch we still just re-resolve everything. I have a followup that
> will construct invalidation rulesets for each query. We'll only invalidate
> the associated elements and only when the query result changes.

Sure, when media queries change we just re-resolve everything, and the rulesets for each query would fix that indeed.

My question was more about whether this patch changes the RuleFeatures that end up being used for class / id / etc invalidations. Which it would, but your followup would address that as well. So that sounds great.

> Explicit { } here allows compact struct initialisation
> 
> auto mediaQueryCollector = MediaQueryCollector { evaluator,
> canUseDynamicMediaQueryResolution };
> 
> without providing explicit constructor.

Fancy, TIL, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191216/487fff24/attachment.htm>