[Webkit-unassigned] [Bug 202739] [GTK][WPE] Renderization of Conic gradients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202739

--- Comment #21 from Diego Pino <dpino at igalia.com> ---
Thanks Carlos for your patience and multiple reviews.

I updated the code to get rid of the static declarations at the beginning of `GradientCairo.cpp` and rearranged the code accordingly.

The reason why the iOS/Mac ports started to fail was that there has been a major refactoring in `Gradient.h`. My patch added an additional piece of information (the radius) to ConicData (Gradient.h). However, this data is not part of the spec (https://www.w3.org/TR/css-images-4/#conic-gradients).

Thus, I have removed in the last update the computation of the radius in `Gradient.h`. However, the GTK/WPE ports need a radius to compute the conic gradient (or at least the width and height of the area in where to paint). The Mac port passes a rect when computing the gradient so that information is implicit, but the GTK/WPE ports simply pass an alpha color. So, I had a dilemma I either change the GTK/WPE API of `createPlatformGradient` or I use a large value for the radius which will later be clipped. I opted for the latter solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191216/1612072c/attachment.htm>