[Webkit-unassigned] [Bug 205217] Nullptr crash if SVG element if element parent becomes document node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205217

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #385646|review?                     |review-
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 385646
  --> https://bugs.webkit.org/attachment.cgi?id=385646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385646&action=review

> Source/WebCore/rendering/svg/RenderSVGText.cpp:377
> +    } else if (m_needsTextMetricsUpdate) {
> +        RenderSVGRoot* rootObj = SVGRenderSupport::findTreeRootObject(*this);
> +        if (rootObj && rootObj->isLayoutSizeChanged()) {

This implements &&, but in the old code it was ||.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191214/7b6a452c/attachment.htm>