[Webkit-unassigned] [Bug 202739] [GTK][WPE] Renderization of Conic gradients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202739

--- Comment #18 from Diego Pino <dpino at igalia.com> ---
Amended messaged "Reviewed by" and reformatting of function declarations.

Regarding the other two issues:

  - The functions declaration at the beginning of GradientCairo are only meant to be used in this file, that's why I declared them as static (they're not meant to be exported). From my point of view, they don't belong to a header file because they're static functions. In fact, the reason why I declared these functions in first place was to allow calling them at any point in the code (otherwise functions can only call functions that were implemented before). If this is not a common practice in the WebKit codebase I can remove these declarations and rearrange the order of the functions.

  - About the guards for GTK and WPE, the reason is that in previous patches all EWS were passing except WinCairo. It failed on a compilation error. I looked into the log (https://ews-build.webkit.org/#/builders/12/builds/11280) but I couldn't figure out what was the issue. Eventually I decided to wrap the relevant code with #ifdefs for GTK and WPE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191212/c0f1d8e5/attachment.htm>