[Webkit-unassigned] [Bug 204977] REGRESSION(r253231): Debug assertion failures under ~WebDeviceOrientationUpdateProvider(Proxy)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204977

--- Comment #5 from David Quesada <david_quesada at apple.com> ---
(In reply to Per Arne Vollan from comment #4)
> Comment on attachment 385085 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385085&action=review
> 
> Thanks for fixing this! R=me.
> 
> > Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp:49
> > +    WebProcess::singleton().removeMessageReceiver(Messages::WebDeviceOrientationUpdateProvider::messageReceiverName(), m_pageIdentifier);
> 
> The WebPage is already being stored, could you call m_page.identifier()
> instead?
> 
> > Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h:57
> > +    WebCore::PageIdentifier m_pageIdentifier;
> 
> Is this member needed, if you get the identifier from m_page?

I originally added ASSERT(m_page) and used m_page->identifier() in the destructor, but m_page ended up being null at this point in some tests. It seemed reasonable to save a copy of the page ID, given that the reference to the page is weak and WebDeviceOrientationUpdateProvider already has a few null-checks for m_page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191207/df406a4d/attachment-0001.htm>