[Webkit-unassigned] [Bug 204977] REGRESSION(r253231): Debug assertion failures under ~WebDeviceOrientationUpdateProvider(Proxy)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204977

Per Arne Vollan <pvollan at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #385085|review?                     |review+
              Flags|                            |

--- Comment #4 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 385085
  --> https://bugs.webkit.org/attachment.cgi?id=385085
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=385085&action=review

Thanks for fixing this! R=me.

> Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp:49
> +    WebProcess::singleton().removeMessageReceiver(Messages::WebDeviceOrientationUpdateProvider::messageReceiverName(), m_pageIdentifier);

The WebPage is already being stored, could you call m_page.identifier() instead?

> Source/WebKit/WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.h:57
> +    WebCore::PageIdentifier m_pageIdentifier;

Is this member needed, if you get the identifier from m_page?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191207/510499ff/attachment.htm>