[Webkit-unassigned] [Bug 204937] Support for resolving highlight pseudo element style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204937

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #384996|review?                     |review+
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 384996
  --> https://bugs.webkit.org/attachment.cgi?id=384996
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384996&action=review

> LayoutTests/ChangeLog:9
> +        * highlight/highlight-pseudo-element-style-expected.txt: Added.
> +        * highlight/highlight-pseudo-element-style.html: Added.

OK for now but the tests should really all be web platform tests.

> LayoutTests/highlight/highlight-pseudo-element-style.html:7
> +::highlight(green-range) { color: green }
> +span::highlight(blue-range) { color: blue }

Would be good to test a style that ::highlight sets but span::highlight does not.

> Source/WebCore/ChangeLog:25
> +        * css/SelectorChecker.h:
> +        * css/parser/CSSSelectorParser.cpp:
> +        (WebCore::CSSSelectorParser::consumePseudo):
> +        * rendering/style/RenderStyle.h:
> +        * style/ElementRuleCollector.cpp:
> +        (WebCore::Style::ElementRuleCollector::ruleMatches):
> +        * style/ElementRuleCollector.h:
> +        (WebCore::Style::PseudoElementRequest::PseudoElementRequest):
> +
> +        Add the requested highlight name.

How does code discover the names of all the applicable highlights for a given element?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191206/c6d8443c/attachment.htm>