[Webkit-unassigned] [Bug 204715] [GTK] WebKitGTK build hangs on g-ir-scanner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204715

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com
 Attachment #385005|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 385005
  --> https://bugs.webkit.org/attachment.cgi?id=385005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385005&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.h:181
> -    static const SocketConnection::MessageHandlers s_messageHandlers;
> +    static const SocketConnection::MessageHandlers& getMessageHandlers();

getMessageHandlers() -> messageHandlers()

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp:97
> +    static SocketConnection::MessageHandlers *messageHandlers = new SocketConnection::MessageHandlers({

Use NeverDestroyed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191206/c2d064e6/attachment.htm>