[Webkit-unassigned] [Bug 204885] [LFC][IFC] Many render tree dump tests show 1px too narrow runs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204885

zalan <zalan at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #384899|review?                     |review+
              Flags|                            |

--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 384899
  --> https://bugs.webkit.org/attachment.cgi?id=384899
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384899&action=review

> Source/WebCore/layout/inlineformatting/text/TextUtil.cpp:74
> +    return std::max(0_lu, LayoutUnit::fromFloatRound(width));

Please add a some words here so that it's clear why we do this random (and presumably temporary) rounding. So I guess the reason why SLL uses float everywhere is to match ComplexLineLayout results. This is very unfortunate and probably fails over time with accumulated rounding. I wish we could essentiallyEqual the layout tests the same way LayoutContext::verifyAndOutputMismatchingLayoutTree does. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191205/d6cf1180/attachment-0001.htm>