[Webkit-unassigned] [Bug 204886] New: computeIfUsingFuzzerAgent() is called before parsing command line arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204886

            Bug ID: 204886
           Summary: computeIfUsingFuzzerAgent() is called before parsing
                    command line arguments
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tuomas.webkit at apple.com

computeIfUsingFuzzerAgent(); is called in the lambda inside Options::initialize() which is invoked at the top of CommandLine::parseArguments().

The options are only set later in CommandLine::parseArguments() at

> if (!JSC::Options::setOption(&arg[2])) {

This means that computeIfUsingFuzzerAgent(); will always determine that no FuzzerAgents are in use because at the time of the check all relevant options are still false regardless of the command line.

similarly I don't believe this will ever be executed either:
>     if (Options::dumpOptions()) {
>       printf("Command line:");

the thing that actually dumps the options with --dumpOptions is at the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191205/8dd9e990/attachment.htm>