[Webkit-unassigned] [Bug 204338] [WinCairo] Refine initialization and error handling in RemoteInspectorSocket

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204338

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Hironori.Fujii at sony.com

--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 383849
  --> https://bugs.webkit.org/attachment.cgi?id=383849
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383849&action=review

> Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:221
> +        LOG_ERROR("createPair() error at getting server port (errno = %d)", WSAGetLastError());

You don't need to include the function name "createPair()" in LOG_ERROR message because it contains.

#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)

I think this LOG_ERROR is unnecessary because getPort prints log if it'd fail.

> Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:224
> +    address.sin_port = htons((u_short)*serverPort);

Why did you add this cast (u_short)? I think it's unnecessary. And, WebKit is merely using C style cast. Use static_cast<u_short>() if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191205/1ea8b681/attachment.htm>