[Webkit-unassigned] [Bug 204874] [WinCairo] Improve Inspectable Target Page to adapt a long title and URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204874

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Hironori.Fujii at sony.com

--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 384881
  --> https://bugs.webkit.org/attachment.cgi?id=384881
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384881&action=review

> Source/WebKit/UIProcess/socket/RemoteInspectorProtocolHandler.cpp:160
> +        "  table, td { border: 1px solid #d3d7cf; border-left: none; border-right: none; table-layout: fixed;}"

I think 'table-layout' should apply only to table element. Why do you want to apply it to td element?

> Source/WebKit/UIProcess/socket/RemoteInspectorProtocolHandler.cpp:165
> +        "  .targeturl { width: auto; color: #babdb6; overflow: hidden; background: #eee; word-wrap: break-word; overflow-wrap: break-word; }"

Why 'width: auto' is needed? Its initial value is 'auto'.
Why 'overflow: hidden' is needed? You are using ellipsis and break-word. Can it overflow?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191205/3cad9bc9/attachment.htm>