[Webkit-unassigned] [Bug 204754] Add exclusion rule for text manipulation SPI to exclude based on element class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204754

--- Comment #6 from Louie Livon-Bemel <llivonbemel at apple.com> ---
(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 384723 [details]
> 57398802-part-2.patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384723&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Tests added as API tests.
> 
> This should instead be:
> Tests:
> TextManipulation.StartTextManipulationApplyInclusionExclusionRulesForClass
>       
> TextManipulation.
> StartTextManipulationApplyInclusionExclusionRulesForClassAndAttribute

Fixed.
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:248
> > +    RetainPtr<_WKTextManipulationConfiguration> configuration = adoptNS([[_WKTextManipulationConfiguration alloc] init]);
> 
> Why not auto?

No specific reason, I'm just in the habit of declaring types since I'm used to Objective-C. I'll make these `auto`.
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:279
> > +    RetainPtr<_WKTextManipulationConfiguration> configuration = adoptNS([[_WKTextManipulationConfiguration alloc] init]);
> 
> Use auto?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191204/68938ff5/attachment-0001.htm>