[Webkit-unassigned] [Bug 204852] [LFC][Integration] Paint with TextPainter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204852

zalan <zalan at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #384812|review?                     |review+
              Flags|                            |

--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 384812
  --> https://bugs.webkit.org/attachment.cgi?id=384812
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384812&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:188
> +        if (textContext.start() == textContext.end())

!textContext.length()

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:196
> +        LayoutRect rect = run.logicalRect();
> +        FloatRect visualOverflowRect = computeOverflow(style, rect, viewportSize);

why no auto? (also in a few places further down)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191204/d47f2d27/attachment.htm>