[Webkit-unassigned] [Bug 204754] Add exclusion rule for text manipulation SPI to exclude based on element class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204754

--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 384723
  --> https://bugs.webkit.org/attachment.cgi?id=384723
57398802-part-2.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384723&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:283
> +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forAttribute:@"data-exclude" value:@"yes"] autorelease],
> +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)NO forAttribute:@"data-exclude" value:@"no"] autorelease],
> +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forClass:@"exclude"] autorelease],

Nit - I don’t think you need the (BOOL) casts here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191204/b0cfdc69/attachment-0001.htm>