[Webkit-unassigned] [Bug 204754] Add exclusion rule for text manipulation SPI to exclude based on element class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204754

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #384723|review?                     |review+
              Flags|                            |

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 384723
  --> https://bugs.webkit.org/attachment.cgi?id=384723
57398802-part-2.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384723&action=review

> Source/WebCore/ChangeLog:9
> +        Tests added as API tests.

This should instead be:
Tests: TextManipulation.StartTextManipulationApplyInclusionExclusionRulesForClass
       TextManipulation.StartTextManipulationApplyInclusionExclusionRulesForClassAndAttribute

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:248
> +    RetainPtr<_WKTextManipulationConfiguration> configuration = adoptNS([[_WKTextManipulationConfiguration alloc] init]);

Why not auto?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:279
> +    RetainPtr<_WKTextManipulationConfiguration> configuration = adoptNS([[_WKTextManipulationConfiguration alloc] init]);

Use auto?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191204/a29df4be/attachment.htm>