[Webkit-unassigned] [Bug 204796] [iOS 13] Crash in NetworkProcessProxy::takeUploadAssertion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204796

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cdumez at apple.com

--- Comment #1 from Chris Dumez <cdumez at apple.com> ---
(In reply to Ali Juma from comment #0)
> Chrome for iOS is getting a moderate number of crashes reported in
> NetworkProcessProxy::takeUploadAssertion, which seem to be from
> WebProcessPool::setWebProcessHasUploads calling takeUploadAssertion on a
> null m_networkProcess.
> 
> We don't have steps to reproduce, but this happens most commonly on
> https://www.homedepot.com, on various product pages and search pages (e.g.,
> https://www.homedepot.com/p/Supreme-Oil-Supreme-Deep-Frying-Oil-with-PNT-Oil-
> 384-fl-oz-1879/202532163,
> https://www.homedepot.com/s/fence%2520staples?searchtype=suggest&NCNI-5).
> 
> All reports are from iOS 13.0 and above, including 13.3 beta.
> 
> Would checking for a null m_networkProcess in
> WebProcessPool::setWebProcessHasUploads be an appropriate fix?

In my opinion, we should call ensureNetworkProcess() instead of doing a null-check, but Brady wrote this piece for code I believe so he may know better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191203/ec338fa0/attachment.htm>