[Webkit-unassigned] [Bug 204785] New: Web Inspector: add WI.EngineeringSetting and WI.DebugSetting to avoid callsite checking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204785

            Bug ID: 204785
           Summary: Web Inspector: add WI.EngineeringSetting and
                    WI.DebugSetting to avoid callsite checking
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

We have lots of `WI.isEngineeringBuild && WI.settings.engineering___.value` anywhere we need to use engineering settings (similar case for debug settings), when in reality the callsites really don't need to be concerned with this logic.  Ideally, they'd just get the engineering/debug setting's value and the value getter itself would know whether to use the actual value or the default value based on `WI.isEngineeringBuild`/`WI.isDebugUIEnabled`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191203/57bd7f9a/attachment.htm>