[Webkit-unassigned] [Bug 204758] Add helper methods for description and equality to text manipulation SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204758

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #384650|review?                     |review+
              Flags|                            |

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 384650
  --> https://bugs.webkit.org/attachment.cgi?id=384650
57438200-part-2.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384650&action=review

LGTM, with a couple of very minor comments.

> Source/WebKit/ChangeLog:35
> +            The general description for should not include the webpage content.

Nit - “…description for should not…”

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm:27
>  #import "_WKTextManipulationItem.h"

Nit - we typically leave a newline below the primary header.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191202/cb6e91f3/attachment-0001.htm>