[Webkit-unassigned] [Bug 204758] Add helper methods for description and equality to text manipulation SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204758

David Quesada <david_quesada at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david_quesada at apple.com

--- Comment #3 from David Quesada <david_quesada at apple.com> ---
Comment on attachment 384640
  --> https://bugs.webkit.org/attachment.cgi?id=384640
57438200.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384640&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm:57
> +- (BOOL)isEqualToTextManipulationItem:(_WKTextManipulationItem *)otherItem includingContentEquality:(BOOL)includingContentEquality

It seems like this class should maybe also have an override of -isEqual: which calls this method with some value for `includingContentEquality`.

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationItem.mm:83
> +- (NSString *)privacyPreservingDescription

This pattern doesn't seem common in WebKit. Is there any reason you decided not to make -description return the privacy-preserving string and implement -debugDescription to return the full string when called from the debugger?

> Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.mm:29
>  @implementation _WKTextManipulationToken

Ditto my comments about the description and equality methods in this class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191202/f0e8fd50/attachment.htm>