[Webkit-unassigned] [Bug 203898] Add FuzzerAgent that reads predictions from a file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203898

--- Comment #24 from Tuomas Karkkainen <tuomas.webkit at apple.com> ---
(In reply to Mark Lam from comment #23)
> Comment on attachment 384592 [details]
> proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384592&action=review
> 
> > Source/JavaScriptCore/runtime/VM.cpp:471
> >          setFuzzerAgent(makeUnique<RandomizingFuzzerAgent>(*this));
> >      if (Options::useDoublePredictionFuzzerAgent())
> >          setFuzzerAgent(makeUnique<DoublePredictionFuzzerAgent>(*this));
> > +    if (Options::useFileBasedFuzzerAgent())
> > +        setFuzzerAgent(makeUnique<FileBasedFuzzerAgent>(*this));
> > +    if (Options::usePredictionFileCreatingFuzzerAgent())
> > +        setFuzzerAgent(makeUnique<PredictionFileCreatingFuzzerAgent>(*this));
> 
> If the user sets more than 1 fuzzer agent, only the last fuzzer agent will
> take effect, and we'll silently fail to use the earlier fuzzer agents.  I
> think we should not be silently failing, and commented about this in
> https://bugs.webkit.org/show_bug.cgi?id=203898#c15.  Did you disagree with
> that assessment?

I made that into a separate patch at https://bugs.webkit.org/show_bug.cgi?id=204607

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191202/e5ac818e/attachment.htm>