[Webkit-unassigned] [Bug 201056] New: serial_test_WTFOptionSetProvider_empty should assert that provider.size == 0 and extract last child is m_storage into separate test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 15:14:23 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=201056

            Bug ID: 201056
           Summary: serial_test_WTFOptionSetProvider_empty should assert
                    that provider.size == 0 and extract last child is
                    m_storage into separate test
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org

Following the fix for bug #200742 I realized that the test named serial_test_WTFOptionSetProvider_empty [1] would be more intuitive to understand if it asserted that provider.size == 0. We should then add another unit test that checks that the last synthetic child is 'm_storage' (we always place this as the last synthetic child, the synthetic provider never includes it in the child count though to prevent it from showing up when listing the synthetic children).

[1] <https://trac.webkit.org/browser/trunk/Tools/lldb/lldb_webkit_unittest.py?rev=248531#L185>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190822/67c79e61/attachment.html>


More information about the webkit-unassigned mailing list