[Webkit-unassigned] [Bug 201024] [Picture-in-Picture Web API] Implement HTMLVideoElement.requestPictureInPicture() / Document.exitPictureInPicture()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201024

Carlos Eduardo Ramalho <cadubentzen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #376975|0                           |1
        is obsolete|                            |

--- Comment #7 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
Created attachment 377047

  --> https://bugs.webkit.org/attachment.cgi?id=377047&action=review

WIP

- Implements Document.exitPictureInPicture()
- Adds Logging utilities

As a next step I should probably refactor this messy code into a central "controller" or "manager" class, owned by Document, which gathers the spec algorithms.

The current code is breaking inheritance and has no clearly defined lifetimes.

Nevertheless, it should be able to enter/exit PIP using the API now.

Running the WPT tests with https://w3c-test.org/tools/runner/index.html gives:

Passed:   8
Failed:   7
Timeouts: 8
Errors:   0
Not Run:  2

So, some progress.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190822/0f834b48/attachment.html>