[Webkit-unassigned] [Bug 201045] webkit-patch upload: Make file status failure not fatal.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 22 13:48:04 PDT 2019


--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 377030
  --> https://bugs.webkit.org/attachment.cgi?id=377030

View in context: https://bugs.webkit.org/attachment.cgi?id=377030&action=review

> Tools/ChangeLog:8
> +        webkit-patch upload fails on large changes (~2000 files) because the prepare-ChangeLog step tries to
> +        execute a command line that is too long. This change allows webkit-patch upload to continue past
> +        the failure.

Could you please elaborate on why it's acceptable to continue past this failure?

Seems like we should make a decision for how many files we want to put into ChangeLog (too many is impractical), but that's a check that would be made at a different level in the code.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190822/6a131c8d/attachment.html>

More information about the webkit-unassigned mailing list