[Webkit-unassigned] [Bug 201024] [Picture-in-Picture Web API] Implement HTMLVideoElement.requestPictureInPicture() / Document.exitPictureInPicture()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 20:35:39 PDT 2019


--- Comment #1 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
Created attachment 376973

  --> https://bugs.webkit.org/attachment.cgi?id=376973&action=review


WIP patch:
- Implements HTMLVideoElement.requestPictureInPicture()
- Imports WPT tests
- Adds compile flag to XCode (TODO CMake) and runtime flag

Need to implement document.exitPictureInPicture() too for the patch to be self-contained, I think. Should be the minimal for the demo at https://googlechrome.github.io/samples/picture-in-picture/ to work minimally.

Will split this patch into smaller ones for the flags first and need to skip PIP tests too.

However, I accept comments on the requestPictureInPicture() bits.
- Is it OK to use Supplement/Supplementable or it preferable add to HTMLVideoElement directly?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190822/7f541cfc/attachment.html>

More information about the webkit-unassigned mailing list