[Webkit-unassigned] [Bug 193046] Unable to enter text in https://eat.fi

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193046

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #375219|review?                     |review+
              Flags|                            |

--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 375219
  --> https://bugs.webkit.org/attachment.cgi?id=375219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375219&action=review

r=me with the following comments addressed.

> Source/WebCore/html/HTMLEmbedElement.h:46
> +    bool isInteractiveContent() const final { return true; }

Please add this to HTMLAppletElement as well.

> Source/WebCore/html/HTMLIFrameElement.h:56
> +    bool isInteractiveContent() const final { return true; }

And to HTMLFrameElement.

> Source/WebCore/html/HTMLLabelElement.cpp:123
> +    for (const auto* it = &node; it && it != this; it = it->parentOrShadowHostNode()) {

Use parentElement() or parentElementInComposedTree().
It's suspicious that the specification doesn't use the composed tree for the purpose of determining this.
It's probably a specification bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190822/45be19a7/attachment.html>