[Webkit-unassigned] [Bug 201012] New: Layout Test perf/clone-with-focus.html is a Flaky Failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 16:26:15 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=201012

            Bug ID: 201012
           Summary: Layout Test perf/clone-with-focus.html is a Flaky
                    Failure
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: repstein at apple.com

The following layout test is a flaky failure on iOS:

perf/clone-with-focus.html

History:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=perf%2Fclone-with-focus.html

We have some failures such as:

-PASS. Cloning elements takes roughly as long with as without focus.
+FAIL. Cloning 1000 elements with focus took 1ms, without took 0ms.

Where a difference of 1ms leads to a fail, leading to flakiness, which seems wrong given the nature of the test. Other failures (such as the provided diff) have slightly larger time differences.


Spoke with Ryosuke offline, who said the following:
"I think the test is written to fail when cloning with focus is twice is as slow as closing without focus. However, the issue is that the bot / WebKit has gotten fast enough that cloning without focus finishes within 0ms. So twice of that is still 0ms.

We need to increase the number of cloning steps such that the measurement for cloning without focus is at least 10ms."

Diff:

--- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/perf/clone-with-focus-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/perf/clone-with-focus-actual.txt
@@ -1,2 +1,2 @@

-PASS. Cloning elements takes roughly as long with as without focus.
+FAIL. Cloning 1000 elements with focus took 5ms, without took 2ms.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190821/5729f00b/attachment.html>


More information about the webkit-unassigned mailing list