[Webkit-unassigned] [Bug 200854] New: Web Inspector: implement a consistent style and lifecycle for all agents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200854

            Bug ID: 200854
           Summary: Web Inspector: implement a consistent style and
                    lifecycle for all agents
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

After speaking at length offline with Joe about what `enable`/`disable` represent, we've come to the following conclusion:

An agent's `enable`/`disable` controls whether that agent is "allowed" to send events to the connected frontend.  For now, an agent isn't "required" to be `enable`d in order for commands being sent from the frontend to the backend to have any effect (some agents already work this way).  Agents that need other agents to be `enable`d shouldn't ever assume anything about the state of the other agent, and therefore should properly handle the case where that other agent isn't enabled (often this is just returning an error from the command or not sending an event).

As such, we should:
 - add `enable`/`disable` to all domains that have events
    - re-add them to the `Page` domain (partial "undo" of r248454)
    - this does NOT include the `DOM` domain, as that's going to be handled by <https://webkit.org/b/197025>
 - add error messages when `enable` is called if the domain is already enabled
 - add proper checks when agents are referenced by other agents

I think we should move towards a world where `enable`/`disable` is the single entry/exit point for ALL agents, but that can come later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190817/e02f6060/attachment.html>