[Webkit-unassigned] [Bug 200066] Non-callable "handleEvent" property is silently ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200066

--- Comment #15 from Alexey Shvayka <shvaikalesh at gmail.com> ---
(In reply to Darin Adler from comment #14)
> Comment on attachment 376283 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376283&action=review
> 
> Thanks for fixing this!

Thank you for reviewing my patches!

> 
> > Source/WebCore/bindings/js/JSEventListener.cpp:152
> > +            event.target()->uncaughtExceptionInEventHandler();
> 
> I can’t find anything in that tests that checks this. I assume this is
> needed here for the same reason it’s needed above, but how can we test that
> it’s working properly?

Nice catch, we don't have test coverage for this. It implements legacyOutputDidListenersThrowFlag (please see https://dom.spec.whatwg.org/#dispatching-events and https://w3c.github.io/IndexedDB) via IDBRequest::uncaughtExceptionInEventHandler.

I will make a PR to web-platform-tests, submit another patch to re-sync, and update this one to pass new tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190814/3c3364d4/attachment-0001.html>