[Webkit-unassigned] [Bug 200456] [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200456

Jonathan Bedard <jbedard at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #376182|review?                     |review+
              Flags|                            |

--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 376182
  --> https://bugs.webkit.org/attachment.cgi?id=376182
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376182&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:66
> +    */

Not quite sure what the point you're trying to get across with this comment is.

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:78
> +        return false;

We don't need the else because of early return (it's a WebKit code style policy buried somewhere in https://webkit.org/code-style-guidelines/, I think)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190813/04d4e35c/attachment.html>