[Webkit-unassigned] [Bug 200367] AX: don't hard code accessibility bundle directory path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200367

--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 376028
  --> https://bugs.webkit.org/attachment.cgi?id=376028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376028&action=review

Failing to compile on all our iOS build bots, so not ready to land yet.

> Source/WTF/wtf/Platform.h:1501
> +#if PLATFORM(IOS_FAMILY) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500))

This is either correct or incorrect. There’s no space for "just in case" here. We need to understand how the version checking works for Catalyst rather than guessing.

As I said, I would be very surprised if __MAC_OS_X_VERSION_MIN_REQUIRED is a factor, but it’s possible. Can we find someone who can tell us how it works and what is correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190812/7585c7a0/attachment.html>