[Webkit-unassigned] [Bug 200367] AX: don't hard code accessibility bundle directory path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200367

--- Comment #14 from Eric Liang <ericliang at apple.com> ---
(In reply to Darin Adler from comment #13)
> Comment on attachment 376021 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376021&action=review
> 
> > Source/WTF/wtf/Platform.h:1501
> > +#if PLATFORM(IOS_FAMILY) && (__IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500)
> 
> Doesn’t make sense to check __MAC_OS_X_VERSION_MIN_REQUIRED if we first
> check PLATFORM(IOS_FAMILY). Do we intend to have this on for Mac? If so then
> I think it’s more like this:
> 
>     #if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000)
> || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500)
> 

This will only exist on ios13 and catalyst 10.15. I changed to:
#if PLATFORM(IOS_FAMILY) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500))
Is this correct?

> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:339
> > +#endif // USE(APPKIT)
> 
> When it’s a three line long #if/#endif, I think  the comment on the #endif
> makes it harder to read, not easier. So I’d not make this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190810/8ca56fc9/attachment.html>