[Webkit-unassigned] [Bug 200553] New: shouldRespectImageOrientation should be a value in ImageOrientation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200553

            Bug ID: 200553
           Summary: shouldRespectImageOrientation should be a value in
                    ImageOrientation
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com

Currently we have 

1. enum ImageOrientationEnum {

   };

which list the EXIF image orientation values.

2. enum RespectImageOrientationEnum {

   };

which tells whether the image EXIF image orientation is respected or not. The function RenderElement::shouldRespectImageOrientation() returns RespectImageOrientation for the ImageDocument or if the settings().shouldRespectImageOrientation() is true. Otherwise it returns DoNotRespectImageOrientation.

3. struct ImageOrientationDescription {

   };

which combines ImageOrientationEnum and RespectImageOrientationEnum in one structure and can be used with ImagePaintingOptions.

4. class ImageOrientation {

   }

which is a wrapper for ImageOrientationEnum.

5. ImageOrientationEnum RenderStyle::imageOrientation()
   {

   }

which returns the css image-orientation property but it still is under a feature control flag CSS_IMAGE_ORIENTATION. Otherwise it returns DefaultImageOrientation which is OriginTopLeft, i.e. no image orientation.

Instead of having ImageOrientationEnum, ImageOrientationDescription, ImageOrientation and RespectImageOrientationEnum we are going to have a single structure ImageOrientation which is a wrapper for ImageOrientationEnum. The RespectImageOrientation will be represented as a new enum value 'FromImage'. The struct will have a constructor and casting operator such that assigning an enum value and comparing with an enum value will be done implicitly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190808/9c250228/attachment.html>