[Webkit-unassigned] [Bug 200163] JPEGImageDecoder: use libjpeg-turbo RGBA output path even for Adobe transform=0 JPEGs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 7 05:25:18 PDT 2019


--- Comment #18 from Loïc Yhuel <loic.yhuel at softathome.com> ---
(In reply to Fujii Hironori from comment #16)
> Comment on attachment 374964 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374964&action=review
> > Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:302
> >                  m_info.out_color_space = rgbOutputColorSpace();
> It seems that JPEGImageDecoder::outputScanlines doesn't support the case
> out_color_space is BGRA and m_scaled is false.
> I think we should set out_color_space JCS_RGB if m_scaled.
>   m_info.out_color_space = m_scaled ? JCS_RGB : rgbOutputColorSpace();

Yes, r225091 left dead code which wasn't under the flag, but depended on the flag to work properly.

Btw, the generic downsampling code doesn't really makes sense for JPEG, since the library support fractional M/8 scaling (which is faster than full size decoding, let alone the additional manual scaling loop here).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190807/36396c3e/attachment-0001.html>

More information about the webkit-unassigned mailing list