[Webkit-unassigned] [Bug 200406] [results.webkit.org Timeline] Unhook the scroll event when a series/axis have been removed from the container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 5 17:21:15 PDT 2019


--- Comment #7 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 375583
  --> https://bugs.webkit.org/attachment.cgi?id=375583

View in context: https://bugs.webkit.org/attachment.cgi?id=375583&action=review

Along with fixing a few pretty clear correctness bugs, this patch has a HUGE impact on memory usage of timelines, particularly large ones. I've observed about 5x in some cases, probably 2 or 3x on average.

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:69
> +// Check more about Intersection observer API

I would put this in one-line:

// Uses intersection observer: <https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API>

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:380
> +                // We do nothing for those off screen ones

Comment is duplicating what the code says, just remove it.

How would the element be on screen but the stateDiff not?

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:763
> +                // In case of modification white rendering

Nit: while rendering

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190806/81e7860d/attachment.html>

More information about the webkit-unassigned mailing list