[Webkit-unassigned] [Bug 200398] Add an SPI to suppress all WKWebView interactions except scrolling or zooming

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 2 14:01:25 PDT 2019


--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 375450
  --> https://bugs.webkit.org/attachment.cgi?id=375450

View in context: https://bugs.webkit.org/attachment.cgi?id=375450&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3995
> +        [self _startSuppressingSelectionAssistantForReason:WebKit::InteractionIsHappening];

Nit - I feel like this might warrant its own separate suppression reason (InteractionIsHappening is about the new context menu for peek).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4003
> +        [self _didChangeWebViewEditability];

It seems a bit odd to call -_didChangeWebViewEditability here, since web view edibility didn’t really change. Perhaps we could factor out the logic for resetting the double tap gesture into a separate helper method, and then call it from both places?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4004
> +        _webView._dragInteractionPolicy = _WKDragInteractionPolicyDefault;

It seems like this would enable the drag interaction after interaction suppression ends, in the case where a client sets `_webView._dragInteractionPolicy = _WKDragInteractionPolicyAlwaysDisable;` but would then use this SPI to temporarily suppress interactions. We’d probably want to restore _dragInteractionPolicy to its value prior to this call.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190802/06520621/attachment-0001.html>

More information about the webkit-unassigned mailing list