[Webkit-unassigned] [Bug 200165] WebSockets: response Set-Cookie header not handled when using platform APIs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 2 08:20:38 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=200165
youenn fablet <youennf at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #375407|review? |review+
Flags| |
--- Comment #16 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 375407
--> https://bugs.webkit.org/attachment.cgi?id=375407
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375407&action=review
> Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:54
> + , m_request(request)
Could be an r-value and moved here.
> Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:111
> + m_session->networkStorageSession()->setCookiesFromDOM(m_request.firstPartyForCookies(), SameSiteInfo::create(m_request),
The call to setCookiesFromDOM seems strange to me since this is a regular HTTP response processing code path.
Looking at MacOS setCookiesFromDOM implementation, this is mostly ok except that we are doing client-side cookie checks to validate the duration.
If we compare to the WebProcess handshake implementation, this is status quo but I wonder if there is something better we could do here.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190802/c621a3bc/attachment.html>
More information about the webkit-unassigned
mailing list