[Webkit-unassigned] [Bug 200384] New: Web Inspector: create InspectorBackendCommands for each debuggable type for more accurate feature checking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200384

            Bug ID: 200384
           Summary: Web Inspector: create InspectorBackendCommands for
                    each debuggable type for more accurate feature
                    checking
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

`InspectorBackend.domains.${domain}` isn't a truly valid way to feature check, as it indicates what's supported by the WebKit framework underlying whatever's currently being inspected, not what the current inspection target supports.

On iOS, for example, inspecting a `JSContext` will still show `InspectorBackend.domains.DOM` as the `DOMAgent` is supported by WebKit, even though `JSContext`s have no concept of the DOM.  In this example, however, `window.DOMAgent` would NOT exist, as the `availability` check for the `DOM` domain wouldn't pass, meaning that the agent never gets connected.

In order to do more proper feature checking, we should go back to separate InspectorBackendCommands.js for each debuggable type ("itml", "javascript", "web", "service-worker"), and only include what's actually supported by an inspected target of that type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190802/2be67d31/attachment.html>