[Webkit-unassigned] [Bug 200165] WebSockets: response Set-Cookie header not handled when using platform APIs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 1 13:08:38 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=200165
Alex Christensen <achristensen at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #375338|review? |review-
Flags| |
--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375338
--> https://bugs.webkit.org/attachment.cgi?id=375338
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=375338&action=review
Much better.
> Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:109
> + m_session->networkStorageSession()->setCookiesFromDOM(m_request.firstPartyForCookies(), SameSiteInfo::create(m_request),
You should probably check m_session before using it, since it's weak.
> Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:87
> + // FIXME: support extensions and server cookie.
Actually, you should probably make an accessor for m_session on NetworkSocketChannel then move your cookie setting code from NetworkSocketChannel::didConnect to WebSocketTaskSoup.cpp because the cocoa implementation won't be setting cookies like this.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190801/27dbdb47/attachment.html>
More information about the webkit-unassigned
mailing list