[Webkit-unassigned] [Bug 200321] [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200321

--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 375265
  --> https://bugs.webkit.org/attachment.cgi?id=375265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375265&action=review

> Tools/ChangeLog:9
> +        Let the axis' height can be defined in the option. time line

Nit: 'Let the axis' height be defined in the option object.'

> Tools/ChangeLog:10
> +        Compoenent will read these height and automatically set the height for

I think this should be 'The timeline component will use this value to set the padding-top for headers, which allows headers to start in the correct position even with multiple top axises.'

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:512
> +    const canvasHeight = typeof option.height === "number" ? option.height : parseInt(computedStyle.getPropertyValue('--smallSize')) * 5;

This changer makes the default canvasHeight larger too, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190801/bc1a08a5/attachment-0001.html>