[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 07:04:49 PDT 2019


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
 Attachment #375286|review?                     |review+
              Flags|                            |

--- Comment #38 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375286
  --> https://bugs.webkit.org/attachment.cgi?id=375286

View in context: https://bugs.webkit.org/attachment.cgi?id=375286&action=review

r=me with a few nits.
ews failure is unrelated

> Source/WebCore/platform/network/curl/CertificateInfo.h:-79
> -    static bool decode(Decoder&, WebCore::CertificateInfo&)

Please use modern decoding that returns an Optional<WebCore::CertificateInfo>. Decoders that return a bool prevent us from removing default constructors in decodable classes.

> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:171
> +static Optional<String> toString(const ASN1_STRING* name)

These can just return a String, which has a null state.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190801/cd814269/attachment-0001.html>

More information about the webkit-unassigned mailing list