[Webkit-unassigned] [Bug 197412] New: WebCore::StyleColorScheme should not have explicitly-declared copy constructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197412

            Bug ID: 197412
           Summary: WebCore::StyleColorScheme should not have
                    explicitly-declared copy constructor
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

Since we enabled dark mode CSS for GTK, I can't see any real warnings past this warning spam:

[1135/1984] Building CXX object Source/WebCore/CMakeFiles...s/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp.o
In file included from ../../Source/WebCore/rendering/RenderObject.h:35,
                 from ../../Source/WebCore/rendering/RenderElement.h:26,
                 from ../../Source/WebCore/rendering/RenderLayerModelObject.h:25,
                 from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28,
                 from ../../Source/WebCore/rendering/RenderBox.h:26,
                 from ../../Source/WebCore/rendering/RenderLayer.h:51,
                 from ../../Source/WebCore/rendering/svg/SVGRenderingContext.cpp:32,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp:1:
../../Source/WebCore/rendering/style/RenderStyle.h: In member function ‘void WebCore::RenderStyle::setColorScheme(WebCore::StyleColorScheme)’:
../../Source/WebCore/rendering/style/RenderStyle.h:1182:97: warning: implicitly-declared ‘constexpr WebCore::StyleColorScheme& WebCore::StyleColorScheme::operator=(const WebCore::StyleColorScheme&)’ is deprecated [-Wdeprecated-copy]
 1182 |     void setColorScheme(StyleColorScheme supported) { SET_VAR(m_rareInheritedData, colorScheme, supported); }
      |                                                                                                 ^~~~~~~~~
../../Source/WebCore/rendering/style/RenderStyle.h:94:39: note: in definition of macro ‘SET_VAR’
   94 |             group.access().variable = value; \
      |                                       ^~~~~
In file included from ../../Source/WebCore/rendering/style/StyleRareInheritedData.h:41,
                 from ../../Source/WebCore/rendering/style/RenderStyle.h:59,
                 from ../../Source/WebCore/rendering/RenderObject.h:35,
                 from ../../Source/WebCore/rendering/RenderElement.h:26,
                 from ../../Source/WebCore/rendering/RenderLayerModelObject.h:25,
                 from ../../Source/WebCore/rendering/RenderBoxModelObject.h:28,
                 from ../../Source/WebCore/rendering/RenderBox.h:26,
                 from ../../Source/WebCore/rendering/RenderLayer.h:51,
                 from ../../Source/WebCore/rendering/svg/SVGRenderingContext.cpp:32,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-29.cpp:1:
../../Source/WebCore/rendering/style/StyleColorScheme.h:39:5: note: because ‘WebCore::StyleColorScheme’ has user-provided ‘WebCore::StyleColorScheme::StyleColorScheme(const WebCore::StyleColorScheme&)’
   39 |     StyleColorScheme(const StyleColorScheme& other)
      |     ^~~~~~~~~~~~~~~~

The copy constructor should be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190430/2c8f2106/attachment-0001.html>