[Webkit-unassigned] [Bug 197233] [GTK] Back/forward gesture snapshot always times out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 29 05:23:24 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197233

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 368125
  --> https://bugs.webkit.org/attachment.cgi?id=368125
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368125&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1650
> +    priv->viewGestureController = std::make_unique<WebKit::ViewGestureController>(*priv->pageProxy);
> +    priv->viewGestureController->setSwipeGestureEnabled(priv->isBackForwardNavigationGestureEnabled);

This requires to null-check viewGestureController everywhere before using it. And change webkitWebViewBaseViewGestureController() to return a pointer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190429/b3ae35f6/attachment.html>


More information about the webkit-unassigned mailing list