[Webkit-unassigned] [Bug 196685] [GTK] Support prefers-color-scheme media query

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196685

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368221|review?                     |review+
              Flags|                            |

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 368221
  --> https://bugs.webkit.org/attachment.cgi?id=368221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368221&action=review

(In reply to Carlos Garcia Campos from comment #2)
> What I'm not
> sure we will be able to support is the supported color schemes feature. That
> means that if we are in dark mode and page claims to only support light, we
> would render in light mode. And if we are in light mode and page claims to
> only support dark, we would render in dark mode.

>From conversations with Timothy, I believe the behavior on macOS is subtly different than that. The intent is for all pages to be light unless the webpage specifically says it supports dark. That's how macOS avoids all the web compat problems we've suffered with pages that just don't expect to be displayed in dark mode.

For GTK, I think it's OK to do whatever we want that seems to work, including not supporting this at all if it's really slow, but matching the macOS behavior would of course be safest.

> LayoutTests/ChangeLog:8
> +        Unskip css-dark-mode tests and add platform specific results for some of the tests using the suported color

supported

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190425/91be5c10/attachment.html>