[Webkit-unassigned] [Bug 197273] New: DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197273

            Bug ID: 197273
           Summary: DumpRenderTree doesn't call
                    Internals::resetToConsistentState() before the first
                    test
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: lforschler at apple.com

DRT doesn't call Internals::resetToConsistentState() before the first test. This is because it's called inside this block:

void resetWebViewToConsistentStateBeforeTesting(const TestOptions& options)
{
...
    if (gTestRunner) {
        gTestRunner->resetPageVisibility();
        WebCoreTestSupport::resetInternalsObject([mainFrame globalContext]);
        // in the case that a test using the chrome input field failed, be sure to clean up for the next test
        gTestRunner->removeChromeInputField();
    }

and we don't have a gTestRunner yet. [mainFrame globalContext] needs one because it triggers didClearWindowObjectInStandardWorldForFrame: that assumes that one exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190425/54431d24/attachment.html>