[Webkit-unassigned] [Bug 197095] Accessibility text search and selection API enhancements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197095

--- Comment #16 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 367978
  --> https://bugs.webkit.org/attachment.cgi?id=367978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367978&action=review

>>> Tools/DumpRenderTree/AccessibilityUIElement.cpp:291
>>> +        startFrom = JSValueToStringCopy(context, arguments[1], exception);
>> 
>> we should be able to make these RefPtr<> so we don't have to release ourselves
> 
> JSStringRef is an opaque object that cannot be wrapped in a smart pointer like RefPtr since RefPtr doesn't have access to its constructor/destructor.

I think we actually want RetainPtr<JSStringRef> which will take care of the releasing

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190423/e009ec09/attachment.html>