[Webkit-unassigned] [Bug 197192] New: compile error when -DWTF_CPU_ARM64_CORTEXA53=ON set for arm64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197192

            Bug ID: 197192
           Summary: compile error when -DWTF_CPU_ARM64_CORTEXA53=ON set
                    for arm64
           Product: WebKit
           Version: WebKit Local Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kai.7.kang at gmail.com

It removes function JSC::AssemblerBuffer::data() for ARM64 in commit https://trac.webkit.org/changeset/236589/webkit.
But it is required by Cortex A53 from https://trac.webkit.org/changeset/175514/webkit.

When compile webkitgtk in Yocto Project (https://www.yoctoproject.org) for qemuarm64 which a qemu arm64 bsp. It sets '-DWTF_CPU_ARM64_CORTEXA53=ON' and causes webkitgtk 2.24.0 fails with error:

| In file included from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:30,                                                                   
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk
-2.24.0/Source/JavaScriptCore/assembler/MacroAssembler.h:46,                                                                        
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/jit/GPRInfo.h:28,                                                                                     
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/bytecode/ArithProfile.h:28,                                                                           
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28:                                                                   
| /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScr
iptCore/assembler/ARM64Assembler.h:465:48: warning: 'JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister'
is too small to hold all values of 'JSC::ARM64Assembler::RegisterID' {aka 'enum JSC::ARM64Registers::RegisterID'}                   
|                  RegisterID m_compareRegister : 6;                                                                                
|                                                 ^                                                                                 
| In file included from DerivedSources/ForwardingHeaders/wtf/Platform.h:31,                                                         
|                  from DerivedSources/ForwardingHeaders/wtf/ExportMacros.h:32,                                                     
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/runtime/JSExportMacros.h:32,                                                                          
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScriptCore/config.h:32,                                                                                          
|                  from /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk
-2.24.0/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26:                                                                   
| /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScr
iptCore/assembler/ARM64Assembler.h: In member function 'void JSC::ARM64Assembler::nopCortexA53Fix835769()':                         
| /home/kkang/buildarea/wrlx-201902/LIN1019-1104/tmp-glibc/work/aarch64-wrs-linux/webkitgtk/2.24.0-r0/webkitgtk-2.24.0/Source/JavaScr
iptCore/assembler/ARM64Assembler.h:3769:100: error: 'class JSC::AssemblerBuffer' has no member named 'data'                         
|                  if (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data()) + m_buffer.codeSize() -
 sizeof(int32_t)) & 0x0a000000) == 0x08000000))                                                                                     
|                                                                                                     ^~~~                          
| DerivedSources/ForwardingHeaders/wtf/Compiler.h:343:41: note: in definition of macro 'UNLIKELY'                                   
|  #define UNLIKELY(x) __builtin_expect(!!(x), 0)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190423/71401bb4/attachment-0001.html>