[Webkit-unassigned] [Bug 191650] [Curl] Fix Curl Request Scheduler not to release wrong Curl handle when request is cancelled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 23 01:33:11 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=191650

--- Comment #19 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #17)
> (In reply to Takashi Komori from comment #15)
> > Before patch CurlRequest::cancel was using isCompletedOrCancelled but with
> > new patch it isn't using.
> 
> Oh, you are right?
> 
> How about other call sites of isCompletedOrCancelled?
> For example, CurlRequest::pausedStatusChanged?

Introduced m_statusMutex. Now m_curlHandle is not accessed from main thread directly.

> How about other member variables?
> For example, m_formDataStream?

About other variables and functions, we have a plan to re-design scheduler to split tasks for main thread and worker thread completely.
In this ticket, we should focus on fixing curl scheduler's incorrect behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190423/5dd2e2dd/attachment.html>


More information about the webkit-unassigned mailing list