[Webkit-unassigned] [Bug 197095] Accessibility text search and selection API enhancements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197095

--- Comment #14 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 367978
  --> https://bugs.webkit.org/attachment.cgi?id=367978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367978&action=review

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:291
> +        startFrom = JSValueToStringCopy(context, arguments[1], exception);

we should be able to make these RefPtr<> so we don't have to release ourselves

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:188
> +        JSObjectSetPropertyAtIndex(context, arrayObj, i, JSObjectMake(context, elements[i].getJSClass(), new T(elements[i])), 0);

are we going to leak new T() object here? I think so

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:215
> +    return v;

can we WTFMove this back so that we don't have copy the array on return?

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:202
>          JSObjectSetPropertyAtIndex(context, arrayObj, i, JSObjectMake(context, elements[i]->wrapperClass(), elements[i].get()), 0);

does JSObjectMake return an object that needs to be released?

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:229
> +    return v;

this will copy the whole array again on return right? 
can we WTFMove this back instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190422/bc410567/attachment.html>